envoyproxy/envoy

signal handling: refactor some names for clarity

Open

#11,052 创建于 2020年5月4日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)C++ (5,373 fork)batch import
help wantedtech debt

仓库指标

Star
 (27,997 star)
PR 合并指标
 (平均合并 8天) (30 天内合并 378 个 PR)

描述

While working on https://github.com/lyft/envoy-mobile/issue/831 @mattklein123 suggested disabling signal handling. I originally thought he meant the signal handling envoy has for fatal signals using SignalActions, which didn't make much sense in the context we were working in. While I should have understood he meant signal handling for termination, it didn't help that we have several places to "disable signals", and we do so in bazel config, via compiler directives, and in code. We could clean this up and specify which settings work on fatal signals, which on termination signals, etc.

贡献者指南