envoyproxy/envoy

RTDS snapshot should be pinned to each stream

Open

#10,731 创建于 2020年4月9日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)C++ (5,373 fork)batch import
area/runtimehelp wanted

仓库指标

Star
 (27,997 star)
PR 合并指标
 (平均合并 8天) (30 天内合并 378 个 PR)

描述

Title: we should keep runtime's consistency during a request's lifecycle.

Description: runtime layers should be consistent during processing of a request.

Repro steps:

a bug scenario: filter A reads version 1 of runtime snapshot, filter A stopIteration, waits for a some callback result, say on-demand-rds a new Runtime snapshot (version 2) is pushed by RTDS, filter A resume the filter iteration, and filter B now sees version 2 when it reads from loader.runtime().snapshot()

IMO, We should latch the runtime snapshot to a stream during its creation time.

贡献者指南