envoyproxy/envoy

Unify header validation across all codecs (H1, H2 and H3)

Open

#10,646 创建于 2020年4月3日

在 GitHub 查看
 (27 评论) (0 反应) (1 负责人)C++ (5,373 fork)batch import
area/httparea/quicarea/securityhelp wantedtech debt

仓库指标

Star
 (27,997 star)
PR 合并指标
 (平均合并 8天) (30 天内合并 378 个 PR)

描述

Presently H1 and H2 codecs use header validation which is a mix of the codec specific and some checks from nghttp2 library on top of it. This leads to inconsistencies in header validation across codecs and makes header validation hard to audit.

For more information see design specifications.

This change will include:

  1. Adding header validation according to the HTTP spec.
  2. Converting codecs to use unified header validation facility. This will only be applied for Balsa and oghttp2 codecs.

Deployment plan:

  1. Add opt-in for universal header validation for Balsa and oghttp2 in compatibility mode (fully compatible with the http-parser and nghttp2)
  2. After bake-in interval (i.e. one full release cycle) change the feature to opt-out
  3. Turn-off compatibility features to bring HTTP validation to RFC compliance one by one.

贡献者指南