envoyproxy/envoy

stats: inconsistent handling of multiple consecutive dots in stat-names produced via join vs direct encoding

Open

#10,008 创建于 2020年2月11日

在 GitHub 查看
 (1 评论) (0 反应) (1 负责人)C++ (5,373 fork)batch import
area/statshelp wanted

仓库指标

Star
 (27,997 star)
PR 合并指标
 (平均合并 8天) (30 天内合并 378 个 PR)

描述

You can create a multi-segment stat-name by directly encoding it into the table, or by joining multiple existing stat names.

When you encode directly, you can wind up with multiple consecutive dots. When you construct by joining, you can't. The testcase in this commit illustrates the problem:

https://github.com/jmarantz/envoy/commit/6e7367c522c2fb5e77bb1d59cb54817e039bd9c3

TEST_P(StatNameTest, TestIgnoreTrailingDots) {
  EXPECT_EQ("foo.bar", encodeDecode("foo.bar."));
  EXPECT_EQ("foo.bar", encodeDecode("foo.bar..."));
  EXPECT_EQ("foo..bar", encodeDecode("foo..bar"));
  EXPECT_EQ("foo...bar", encodeDecode("foo...bar"));

  StatNamePool pool(*table_);
  SymbolTable::StoragePtr joined = table_->join({makeStat("a"), makeStat(""), makeStat("b")});
  EXPECT_EQ("a..b", table_->toString(StatName(joined.get())));   // FAILS, will be "a.b".

  EXPECT_EQ("", encodeDecode("."));
  EXPECT_EQ("", encodeDecode(".."));
}

贡献者指南