emscripten-core/emscripten

Cryptic `sig is undefined` error in reportUndefinedSymbols() if function signature not available

Open

#17,283 创建于 2022年6月21日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)C++ (27,361 star) (3,519 fork)batch import
good first bughelp wanted

描述

Discussed in https://github.com/emscripten-core/emscripten/discussions/17266

Originally posted by johnwason June 18, 2022 Currently if a function signature is not defined, reportUndefinedSymbols() will simple raise an error sig is undefined, which is not at all helpful. An error handler should be added to check if the value passed to addFunction() does not have sig defined, and report something more useful to the user. See #17264

贡献者指南

技术栈
ccppjavascriptwasm
领域
backendtoolingdeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptEmscripten basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Locate the `reportUndefinedSymbols()` function in Emscripten's JavaScript runtime code. The function currently raises a cryptic 'sig is undefined' error when a function signature is not provided. Review the related discussion (#17266) and issue (#17264) for background. Add a check to verify that `sig` is defined before using it, and provide a more informative error message indicating which function lacks a signature. The fix is likely in a single file within the Emscripten source tree.