emberjs/ember.js

Router Service: Behaves differently in engine context regarding route path

Open

#17,014 创建于 2018年9月28日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)JavaScript (22,437 star) (4,216 fork)batch import
BugHelp WantedRouting

描述

Hey there,

it seems like the router services behaves differently in an engine context compared to {{#link-to}} in views and transitionTo routes.

Example: I want to link to my engine's route called 'overview'. The engine is mounted as 'engine'.

This is the expected and documented behavior: Route: this.transitionTo('overview') Views: {{#link-to 'overview'}}Link{{/link-to}}

Whereas the service requires the mount point additionally: Service: this.routerService.transitionTo('engine.overview')

I think all three ways should require the same route path.

Versions:

  • ember-source: ~3.2.0
  • ember-engines: ~0.5.4

Hopefully, there's no other issue like that, but haven't found any while searching. Thanks!

贡献者指南

技术栈
javascript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Ember.js basicsEmber Engines concept
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
Investigate the router service implementation in ember.js, likely in packages/@ember/routing/lib/router service.js. Compare the behavior of transitionTo in the service vs link to helper and transitionTo on the route. The issue indicates that in an engine context, the service requires the mount point prefix (e.g., 'engine.overview') while other methods do not. Look at how the router service resolves routes relative to the engine's mount point. Check if there is a normalization step missing or if the service should use the engine's root URL. Review any existing tests for router service in engine context under packages/@ember/routing/tests/.