ember-fastboot/ember-cli-fastboot

Update the docs on the third-party-dependencies section to describe dynamic import method

Open

#921 创建于 2023年6月7日

在 GitHub 查看
 (0 评论) (1 反应) (0 负责人)JavaScript (853 star) (163 fork)batch import
good first issue

描述

The docs for third party dependencies describes a rather old technique that involves automatically wrapping your vendor libs in a "fastboot guard". This method a) won't work for anything that is using ember-auto-import and b) won't work in a broccoli-free embroider build

We should update this section to describe the fact that you can use dynamic imports inline with your code that has a fastboot guard on it. This is idiomatic in terms of the wider JS community i.e. don't import things that you know won't work in your environment

贡献者指南

技术栈
javascript
领域
documentationfrontend
议题类型
documentation
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Ember.js basicsJavaScript
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Update the Third Party Dependencies section of the Fastboot docs (addon author guide) to describe dynamic imports with a fastboot guard. The current documentation describes an outdated technique. See the existing guide at https://ember fastboot.com/docs/addon author guide#third party dependencies. No linked PRs or comments. The change is purely documentation.
Update the docs on the third-party-dependencies section to describe dynamic import method · ember-fastboot/ember-cli-fastboot#921 | Good First Issue