elastic/kibana

[Tags] Break with "&"

Open

#199,143 创建于 2024年11月6日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)TypeScript (19,065 star) (8,021 fork)batch import
Feature:Saved Object TaggingTeam:Corebuggood first issuequick-win

描述

Kibana version: 8.15.3 Elasticsearch version: 8.15.3

Describe the bug: The tags break and fail to show results due to ampersand "&"

Steps to reproduce:

  1. Create a tag
  2. Add string with & in between
  3. Search/click for the tag in Dashboards page
  4. Watch it return no results and issue error

Expected behavior: Tags should consider any values in the string value Screenshots (if relevant): Image

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Understanding of Kibana tags featureBasic JavaScript
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Investigate the tags feature in Kibana, focusing on how tag names are handled when they contain special characters like '&'. Examine the URL query parameters and the saved objects API requests for tag related operations. Look into the client side tag selection component, likely in the `plugins/saved objects tagging` or `plugins/dashboard` directory, to identify where the ampersand is not being properly encoded. The fix may involve applying encodeURIComponent when constructing URLs or when sending tag names to the backend.