elastic/kibana

[Management] Number fields accept invalid input

开放

#197,506 创建于 2024年10月23日

 (5 条评论) (0 个反应) (2 位负责人)TypeScript (8,021 个派生)batch import
Team:Kibana Managementbuggood first issue

仓库指标

星标
 (19,065 个星标)
PR 合并指标
 (平均合并 1天 16小时) (30 天内合并 999 个 PR)

描述

While testing https://github.com/elastic/kibana/pull/196527, I noticed that different form fields in Kibana Management plugins accept invalid input in number fields. Examples I noticed:

  • Ingest pipelines creation flow - add processor form
  • ILM creation flow

https://github.com/user-attachments/assets/6a883a7b-0cf4-43e2-bc36-c0ff6d2ebf1b

https://github.com/user-attachments/assets/45e21ff4-fc0d-4ef0-89c9-4dc922e1abfe

I think the e, -, and , characters are allowed by the Eui number field itself and it contains some validation for valid numbers. We should probably add validations from our side for valid numbers as well and not allow submitting the form if the number is invalid.

贡献者指南