elastic/kibana

[Telemetry] Better error handling at the `telemetry_plugin_collector`

Open

#122,634 创建于 2022年1月11日

在 GitHub 查看
 (4 评论) (1 反应) (0 负责人)TypeScript (19,065 star) (8,021 fork)batch import
Feature:TelemetryTeam:Coregood first issueimpact:lowloe:small

描述

In the telemetry_plugin_collector we are swallowing any errors thrown by getTelemetrySavedObject: https://github.com/elastic/kibana/blob/c2641bd8cc875dd50c63a40fbaf3054780cd570b/src/plugins/telemetry/server/collectors/telemetry_plugin/telemetry_plugin_collector.ts#L45-L52

I don't think that we should do this as we might report different data depending on whether there's an ES connection issue or not (because when there's no savedObject information we rely on the kibana.yml config values).

IMO, we should either let the collector fail or populate the related fields only when getTelemetrySavedObject succeeds.

贡献者指南

技术栈
typescriptnodejs
领域
backendobservability
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
TypeScriptNode.jsElasticsearchKibana telemetry
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
The issue is located in `src/plugins/telemetry/server/collectors/telemetry plugin/telemetry plugin collector.ts` around line 45-52, where errors from `getTelemetrySavedObject` are currently swallowed. The two suggested approaches are to either let the collector fail or only populate fields when the call succeeds. A contributor should evaluate which approach is more appropriate for consistent telemetry data and implement the change. No linked PRs or assignees exist, so this is an open opportunity.