elastic/kibana

[Task Manager] Clean up performance tests

Open

#117,300 创建于 2021年11月3日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)TypeScript (19,065 star) (8,021 fork)batch import
Feature:Task ManagerTeam:ResponseOpsestimate:smallgood first issuetechnical debt

描述

With https://github.com/elastic/kibana/pull/117294, we are removing the perf_hooks in task manager due to possible memory leakage. There is also a set of skipped functional tests in https://github.com/elastic/kibana/blob/main/x-pack/test/plugin_api_perf/test_suites/task_manager/index.ts that we should make sure to remove once we've confirmed that 🤞 removing the perf_hooks fixes the memory issue.

贡献者指南

技术栈
typescriptnodejs
领域
backendtestingperformance
议题类型
test
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Familiarity with Kibana task managerContext from PR #117294
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
First, verify that PR #117294 has resolved the memory leak issue and is merged. Then, locate the file x pack/test/plugin api perf/test suites/task manager/index.ts in the Kibana repository. Remove the functional tests that are currently skipped (likely marked with `skip` or `xdescribe`). Ensure the tests are no longer needed and that no other parts of the codebase depend on them. Finally, submit a pull request to remove the skipped tests and any references to the old perf hooks usage if not already cleaned up.