elastic/kibana

Edit role page allows you to exit before changes are saved

Open

#106,576 创建于 2021年7月22日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)TypeScript (19,065 star) (8,021 fork)batch import
Team:Securityenhancementgood first issue

描述

Related: #42503

Kibana version: 7.14.0 and earlier

Describe the bug:

Creating (or editing) a role takes several steps:

  • Add ES privileges
  • Add Kibana privileges
  • Click the "Save role" (or "Create role") button

This is particularly easy to overlook when you are adding a Kibana privilege, because there is a filled in "Add Kibana privilege" (or "Update space privilege") button

Steps to reproduce:

  1. Navigate to Stack Management > Roles
  2. Create or edit a role
  3. Change the role and navigate to a different page
  4. Observe that Kibana lets you leave without saving the role

Expected behavior:

  1. The "Add Kibana privilege" (or "Update space privilege") button on the Kibana privileges flyout should be renamed and/or made less prominent (changed to an outline button?); it's too easy to mistake that that actually updates the role when it doesn't. Also, these names should be more similar (perhaps they can both just be "Continue"?)
  2. If changes are detected but not saved, we should probably catch the user before they navigate away from the page. Note that we should make sure session timeout is not negatively impacted.

Screenshots (if relevant):

image

image

贡献者指南

技术栈
typescriptreact
领域
frontendsecurity
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Kibana basicsTypeScriptReactUI navigation patterns
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Start by exploring the Kibana role management UI, likely in the `x pack/plugins/security` directory. Look for components related to the role editor and the Kibana privileges flyout (files such as `edit role page.tsx` or `kibana privileges flyout.tsx`). The fix involves two parts: first, modify the button label and styling to differentiate it from the save action; second, add a navigation guard using `beforeunload` or React Router's `Prompt` to warn users about unsaved changes. Check existing tests in the same directory for guidance on testing the changes. The issue #42503 may have additional context.
Edit role page allows you to exit before changes are saved · elastic/kibana#106576 | Good First Issue