elastic/elasticsearch

Share number based field mapper test code with other modules

Open

#92,947 创建于 2023年1月16日

在 GitHub 查看
 (17 评论) (2 反应) (0 负责人)Java (76,700 star) (25,882 fork)batch import
:Search Foundations/Mapping>testTeam:Search Foundationsgood first issue

描述

Move number based field mapper test infrastructure to the test framework module. This would allow other number based field mapper to use the same test infrastructure that the core number field mappers are using.

Currently UnsignedLongFieldMapper and ScaledFloatFieldMapper have their own concrete tests, but could instead make use of NumberFieldMapperTests or WholeNumberFieldMapperTests. This avoids duplicates tests and testing logic.

Furthermore this can avoid that non core field mappers don't get forgotten when new features / behaviour is added to core field mappers.

Originates from #92917

贡献者指南

技术栈
java
领域
testing
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaElasticsearch test infrastructure
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Review the existing NumberFieldMapperTests and WholeNumberFieldMapperTests in the core module to understand the test infrastructure. Also examine UnsignedLongFieldMapper and ScaledFloatFieldMapper tests to see current duplication. The proposed refactoring aims to move shared test utilities to the test framework module. Refer to issue #92917 for further context.