elastic/elasticsearch-py

Helpers for `bulk` method such as `async_bulk` sleep in blocking manner, preventing graceful shutdown

Open

#2,484 创建于 2024年3月22日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)Python (4,060 star) (1,206 fork)batch import
Area: HelpersCategory: Enhancementgood first issue

描述

We tried using async_bulk and async_streaming_bulk helpers to ingest data into Elasticsearch and they work great, but we've found out that they prevent our code from gracefully shutting down when CTRL+C is pressed.

Example code that sleeps: https://github.com/elastic/elasticsearch-py/blob/e1603f4f25888ca7fee03ee977abafb00d512601/elasticsearch/_async/helpers.py#L249-L251

It would be great to have a way to:

  • Either define how the sleep happens by passing sleep function into the client
  • Make Elasticsearch client internally cancel all sleeps when the client is closed

贡献者指南

技术栈
python
领域
backenddata
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Python async programmingElasticsearch client helpers
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Examine the helpers.py file at the linked line (L249 L251) to understand the blocking sleep call. Consider implementing one of the proposed solutions: either allow passing a custom sleep function to the helpers, or make the client cancel all in progress sleeps when closed. Review the existing async helpers for bulk operations and test the fix with a simulated shutdown scenario.