eduaguilera/whep

footprint_uncertainty: propagate_fp_uncertainty accepts malformed probs unvalidated

开放

#215 创建于 2026年7月22日

 (1 条评论) (0 个反应) (0 位负责人)R (3 个派生)auto 404
area:footprintbuggood first issuehelp wantedmechanicalno-data-neededpriority:low

仓库指标

星标
 (1 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

What

propagate_fp_uncertainty() (R/footprint_uncertainty.R:154-169, 185-195) merges options$probs with no length/range check. probs = c(0.05, 0.95) errors only after all n draws are computed (probs[3] → NA in quantile), and unordered probs silently produce q_low > q_high.

Suggested fix / check

Validate probs (length, range [0,1], ordering) at entry before drawing.


From deep static audit (2026-07-22), parallel subsystem review pass. Deduplicated against then-open issues. Not verified by running unless stated.

贡献者指南