eclipse-theia/theia

Issue with multiple comments with Github Pull request plugin

Open

#9,007 创建于 2021年1月30日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)TypeScript (18,676 star) (2,478 fork)batch import
bughelp wantedvscode

描述

Bug Description:

Start Review and Add comment buttons behaves same across multiple comments dialog

Steps to Reproduce:

  1. Refer the steps given in https://github.com/eclipse-theia/theia/pull/8870
  2. Open a file with multiple changes
  3. Open and add reply in both the discussion
  4. Remove the content from one discussion and notice the buttons of both discussion changes

https://user-images.githubusercontent.com/13016475/106349492-34a98800-62f4-11eb-8c4e-3facc77af18b.mov

Additional Information

  • Theia Version: Version 1.10.0

贡献者指南

技术栈
typescriptreactnodejs
领域
frontenddeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
basic knowledge of Theiaunderstanding of GitHub pull request plugin
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
The issue describes that the 'Start Review' and 'Add comment' buttons behave the same across multiple comment dialogs. The steps reference PR #8870. To fix, investigate the plugin code likely located in packages/git or plugins/github. Look for event handling that couples button states incorrectly. Check the linked PR for context on recent changes.