Previous active tab flicker when navigating the top menu, Navigation sometimes disabled when Webview was last focused · eclipse-theia/theia#8572

(1 评论) (0 反应) (0 负责人)TypeScript (18,676 star) (2,478 fork)batch import

help wantedmenusui/uxwebviews

描述

When focusing a tab inside the main panel and then - navigating between the tabs in the top panel - The focused tab inside the main panel flicker, Before menu closes - the previous-focused-tab getting focus even though the user is still on the menu bar - When navigating by keyboard arrows and the previous-focused-tab was a Webview - sometimes the focus not return back to the menu (because focusing on the webview iframe) so navigation is disabled.

Bug Description:

Steps to Reproduce:

For the flicker issue:

Focus on a file
Click on any tab inside the top menu
Navigate between the menu tabs (by mouse/ keyboard)

For the IFrame issue:

Open a webview
Click on any tab in the top menu
Navigate between the menu tabs by keyboard

This is how it flicker: menu

It happens because there's code for restoring the focus before the menu closes, When navigating on menu - the tab first closes - so previous-focused-tab inside main panel is focused and only then - the next selected tab is opened...

Additional Information

Operating System: Windows
Theia Version: Master

贡献者指南

技术栈: typescript
领域: frontend
议题类型: bug
难度: 3
预计时间: half day
活动状态: stale
清晰度: mostly clear
前置要求: Understanding of focus management in web applicationsFamiliarity with Theia's menu and tab system
新手友好度: 30
研究方向: Investigate the focus restoration logic in the menu closing sequence. The issue mentions that when navigating the top menu, the previous active tab gains focus before the new tab opens, causing flicker. Look for code that restores focus when menu closes and modify it to only restore after the new tab is selected. Also handle the WebView iframe case to prevent focus loss.