eclipse-theia/theia

Half-Hidden tab getting close while not clicking on close button

开放

#8,431 创建于 2020年8月25日

 (1 条评论) (0 个反应) (0 位负责人)TypeScript (2,478 个派生)batch import
bughelp wantedui/ux

仓库指标

星标
 (18,676 个星标)
PR 合并指标
 (平均合并 15天 4小时) (30 天内合并 75 个 PR)

描述

Bug Description:

When you are clicking at the right most part of a half-hidden tab, the tab in question gets closed (Zone highlighted in red) : image

Steps to Reproduce:

  1. Open many files
  2. Scroll your tabs to have on tab half hidden to the right of the tabbar
  3. click on the right most part of the tab

Additional Information

This error comes from PhosphorJS which is now abandonned as discussed in this thread : https://github.com/eclipse-theia/theia/issues/6501 In phosphorJS tabbar when the mousedown event is received, the tab that is clicked becomes the default one, so the tabbar gets centered on this tab. In the mouse up event, there is a check if the click was made on the close icon. This check returns true because now the tabbar was recentered on the tab clicked and so the click calls the close tab. I checked with VSCode and in this case, the tab only gets selected : not closed

  • Operating System: Any
  • Theia Version: Latest

贡献者指南