eclipse-theia/theia

tree-view: support for 'view action' commands without icons

Open

#8,246 创建于 2020年7月27日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)TypeScript (18,676 star) (2,478 fork)batch import
enhancementhelp wantedvscode

描述

Feature Description:

The feature is to support commands without icons as inline view-actions.

At the moment, if a command does not define an icons property and is used as an inline view action it will not be rendered in the framework. The following is supported in vscode as the label is used instead.

For example, the following command is displayed as the following:

"commands": [
  {
    "command": "nodeDependencies.refreshEntry",
    "title": "Refresh"
  }
]

Additional Information

贡献者指南

技术栈
typescript
领域
frontenddeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
VS Code extension API knowledgeTheia tree view component structure
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
The issue asks to support view actions without icons by using the command title as a fallback. Start by examining the Theia source code for tree view rendering, specifically the part that handles view actions. The issue references a sample extension (vscode tree view example label) that demonstrates the expected behavior in VS Code. Look for where icon presence is checked and modify to allow a label fallback. The fix is likely in the tree view widget or action rendering logic.
tree-view: support for 'view action' commands without icons · eclipse-theia/theia#8246 | Good First Issue