eclipse-theia/theia

workspace: correct the file filters for 'open workspace...'

Open

#8,179 创建于 2020年7月15日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)TypeScript (18,676 star) (2,478 fork)batch import
dialogsfile dialoghelp wantedworkspace

描述

Bug Description:

The 'open workspace...' dialog incorrectly includes the 'all files' filter meaning that the application allows any file to be opened as a workspace which is incorrect. There is logic to reject opening the file if it is not of the correct type, but we should also adjust the filter as to not be able to choose incorrect file types.

The correct file types are the following only:

  • *.theia-workspace
  • *.code-workspace

Steps to Reproduce:

  1. start the application (browser or electron)
  2. trigger the open workspace... command
  3. notice that the all files filter is set
  4. attempt to open a file which is not correct (an error should appear)
  5. we should fix the filter to correct this issue

贡献者指南

技术栈
typescriptjavascriptnodejs
领域
frontenddeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
无
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
Look for the 'open workspace' dialog implementation in the Theia frontend, likely in the workspace plugin (e.g., packages/workspace). Identify where file filters are set for the dialog and modify them to include only '*.theia workspace' and '*.code workspace'. Ensure consistency with existing rejection logic that validates workspace files.