eclipse-theia/theia

Terminal commands missing in certain instances.

Open

#8,100 创建于 2020年6月26日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)TypeScript (18,676 star) (2,478 fork)batch import
bugcommandshelp wantedquick-open

描述

Bug Description:

The isEnabled handler for many terminal commands may be incorrect. If you give the terminal focus and use CTRL+SHIFT+P you will see commands like clear terminal, however, if you use CTRL+P then type >, you will not see this command. My thinking is that the isEnabled handler is looking at the focused widget, which in the case of CTRL+P, >, is probably the quick open.

Steps to Reproduce:

  1. Use CTRL+P, > with terminal focused, look for Terminal: Clear
  2. Use CTRL+SHIFT+P, with terminal focused, look for Terminal: Clear

Additional Information

  • Operating System: Linux lnx 5.3.0-59-generic #53~18.04.1-Ubuntu SMP Thu Jun 4 14:58:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
  • Theia Version: 1.2

贡献者指南

技术栈
typescript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Understanding of Theia's command isEnabled handlersKnowledge of widget focus in Theia
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Investigate the isEnabled handler in packages/terminal/src/browser/terminal frontend contribution.ts (line 283) to understand how it checks the currently focused widget. The issue is that when using CTRL+P, the quick open widget takes focus, hiding terminal commands. A possible fix is to check if the terminal widget is among the active widgets in the shell, not just the focused one. Review the quick open widget's focus management and ensure that the terminal commands appear when the terminal has focus or is the active tab.