eclipse-theia/theia

Find & Replace is not fully functional for keyboard users.

Open

#8,055 创建于 2020年6月19日

在 GitHub 查看
 (7 评论) (0 反应) (0 负责人)TypeScript (18,676 star) (2,478 fork)batch import
accessibilityhelp wantedsearch in workspace

描述

Bug Description:

In both Theia and VS Code pressing enter in the focused input(where the new value is entered in find and replace) does not replace the contents I have to manually click on the small icon next to the input. I was expecting it to work when the enter key is pressed.

Peek 2020-06-19 17-22

To me, it looks like a serious accessibility issue for Keyboard users and generally, it would be great if the whole Theia IDE is accessible for those users who only use a keyboard and can't use a mouse.

Steps to Reproduce:

  1. Open a Gitpod workspace.
  2. Try to find and replace some text via the Keyboard.

Additional Information

  • Operating System:
  • Theia Version:

贡献者指南

技术栈
typescript
领域
frontendaccessibility
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic knowledge of Theia widget extensionsTypeScript
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
45
研究方向
The bug is in the find/replace widget of Theia. The issue is that pressing Enter in the replace input field does not trigger the replace action; users must click the replace button. To fix, locate the widget code in the theia repository, likely under packages/editor or packages/find replace. Add a keydown event listener for Enter that programmatically clicks the replace button or triggers the replace command. Check how the replace button's click handler is bound and replicate that on Enter press.