eclipse-theia/theia

Preference change does not fire an onPreferencedChanged event

Open

#7,685 创建于 2020年4月28日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)TypeScript (18,676 star) (2,478 fork)batch import
bughelp wantedpreferences

描述

Bug Description:

While working on the new preferences-ui we came across a bug related to the preference-service that has been causing some strange and unpredictable behavior on the Electron version (and also appears on master with the original preferences UI). When setting a preference value for some items, most noticeably Application Confirm Exit in User scope, the preference service does not properly register an onPreferenceChanged event, and thus does not update the value in the UI. This has sometimes occurred for other preference items in folder scopes as well, but is consistently an issue for Application Confirm Exit Please see the attached screen recording with console output:

Steps to Reproduce:

  1. Set up a log for the preferenceService.onPreferenceChanged event (in e.g. packages/preferences/src/browser/preferences-decorator.ts around line 36)
  2. Build for Electron
  3. Run in Electron
  4. Open Preferences in User scope
  5. Modify preferences using tree view and save the JSON
  6. Every modify + save cycle should fire an onPreferenceChanged event.
  7. Modify 'Application: Confirm Exit' and save
  8. Observe that no event fires

screenrecord

Additional Information

  • Operating System: Linux (RHEL7 & Ubuntu tested)
  • Theia Version: Electron 1.0.0

贡献者指南

技术栈
typescriptelectronnodejs
领域
full stackdesktop
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
TypeScriptTheia frameworkEvent driven programming
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Start by examining the preference service event emission in packages/preferences/src/browser/preferences decorator.ts (around line 36). Investigate why the 'Application: Confirm Exit' preference in User scope does not trigger onPreferenceChanged. Check the implementation of preference service to see if the event is properly registered and if the change is detected. Review the issue comments for any additional context or hints.
Preference change does not fire an onPreferencedChanged event · eclipse-theia/theia#7685 | Good First Issue