eclipse-theia/theia

[keybinding][windows] Keybinding collisions

Open

#6,153 创建于 2019年9月10日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)TypeScript (18,676 star) (2,478 fork)batch import
OS/Windowsbughelp wantedkeybindingsterminal

描述

Description

There is a keybinding collision in Theia. Happens on Windows.

root WARN Collided keybinding is ignored;  {"command":"passthrough","keybinding":"ctrl+k","context":"terminalActive"}  collided with  {"command":"terminal:clear","keybinding":"ctrlcmd+k","context":"terminalActive"}

root WARN Could not register keybinding:
  {"command":"passthrough","keybinding":"ctrl+k","context":"terminalActive"}
Error: "ctrl+k" is in collision with something else [scope:0]

Reproduction Steps

Start Theia on Windows.

OS and Theia version: Windows a9a39db21 Diagnostics:

贡献者指南

技术栈
typescript
领域
developer experiencetooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Understanding of Theia's keybinding systemFamiliarity with Windows key modifiers
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Investigate the keybinding registration code in Theia, specifically in packages/keybindings. Look for how 'ctrl+k' and 'ctrlcmd+k' are defined and handled on Windows. The collision occurs in the terminalActive context. Check if the platform specific key mapping is causing the conflict, and consider adding a platform conditional or adjusting the keybindings. Review the error message logic in generateKeybindings.ts or similar files.