eclipse-theia/theia

URL path escapes '@' symbol, which breaks the url

Open

#4,927 创建于 2019年4月17日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)TypeScript (18,676 star) (2,478 fork)batch import
help wanted

描述

Description

I have theia running under JupterLab, the username in the url is an email address and contains an @, for example:

/users/rayh@example.com/theia

While I can load the page, the websocket url escapes the @ and therefore breaks the url and the websocket connection cannot be established.

In webpack:///./node_modules/vscode-uri/lib/esm/index.js - if I flip skipEncoding to true, the url now works, but i suspect this will not encode the request params. image

Here is the failing connection: image

Reproduction Steps

Simplest test would be to deploy theia under a url path that contains an '@'

OS and Theia version: Theia 0.5.0 running in Ubutnu 18.04.1 LTS

贡献者指南

技术栈
typescriptnodejs
领域
full stack
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic TypeScriptunderstanding of URL encoding
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
Examine the vscode uri library, specifically the file `lib/esm/index.js` where the `skipEncoding` flag is used. The issue suggests flipping it to `true` fixes the websocket URL, but may affect encoding of other request params. Investigate whether a localized fix can be applied to avoid global changes. Also look at Theia's websocket connection code to see how the URL is constructed and where the encoding occurs. Consider adding a test for URLs containing special characters like '@'.