eclipse-theia/theia

`**` `files.exclude` filter should filter everything in the navigator

Open

#4,300 创建于 2019年2月11日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)TypeScript (18,676 star) (2,478 fork)batch import
bughelp wantednavigator

描述

This is a follow-up issue of #4274. Most likely, nobody wants to filter all items from the navigator, so this is a minor defect.

{
    "files.exclude": {
        "**": true
    }
}

Current behavior: All files with a leading . (dot) are visible in the navigator.

Expected behavior: No files are visible in the navigator.

screencast 2019-02-11 16-51-07

贡献者指南

技术栈
typescript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
无
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
Investigate how the `files.exclude` pattern matching is implemented in Theia's file navigator, specifically the handling of the `**` pattern. The issue states that files with a leading dot are still visible when `**` is set as an exclude pattern. Look at the file tree component and the exclude filter logic to find where the glob matching might incorrectly skip hidden files. Expected fix: ensure that `**` matches all files, including dotfiles.