eclipse-theia/theia

Uncaught Error: Cannot get key code from the keyboard event. Keydown event without code on chrome

Open

#10,702 创建于 2022年2月2日

在 GitHub 查看
 (11 评论) (1 反应) (0 负责人)TypeScript (18,676 star) (2,478 fork)batch import
help wantedkeybindings

描述

Bug Description:

When I click a datalist option linked to an input on Chrome (not Firefox), a keydown event is triggered. This event does not have a key/code/keycode. I don't know if it is a bug of Chrome but in any case, the widget listens keydown events and tries to find the key. Exception is thrown here. The event should probably just be ignored in this case.

This error once happened with electron but it is probably not relevant anymore

Steps to Reproduce:

  1. Create an input and link it with a datalist containing several options in Chrome.
  2. Listen for keydown events.
  3. Click an option
  4. Observe that there is no key information in the event.

Additional Information

  • Operating System: Windows 10, Chrome 97
  • Theia Version: Last, 1.22 (browser)

贡献者指南

技术栈
typescript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
TypeScriptkeyboard eventsChrome browser
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
The error occurs in packages/core/src/common/keys.ts around line 390. When a keydown event lacks a key code (as happens with Chrome's datalist interaction), an uncaught error is thrown. The fix is to add a check to ignore such events. Refer to issue #8157 for prior Electron context. Testing should involve creating an input with a datalist in Chrome and verifying no exception is thrown.