dvdciri/daggraph

Add constructor injected dependencies to the graph

Open

#53 创建于 2018年8月19日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (1,147 star) (61 fork)batch import
featurehelp wanted

描述

Daggraph need to be able to recognise constructor injected dependencies and add them to the graph.

There are some open questions here:

  • Where should we put the class which is constructor injecting some dependencies?
  • Where should we put the injected dependencies?

This is the regex for koltin: /(?:class)\s(\w*).*?(?:@Inject).*?(?:constructor)\((.*?)\)\s?\{/gs This is the regex for java: /(?:@Inject).*?\s(\w*?)\((.*?)\)\s?{/gs

贡献者指南

技术栈
kotlinjava
领域
toolingdeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
regex basicsJava/Kotlin class syntaxDagger dependency injection
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
The issue targets adding constructor injected dependencies to the Daggraph graph. The provided regex patterns for Kotlin and Java need to be integrated into the parser logic. The main files to examine are likely in the parsing module (e.g., `src/parser.js` or similar). Currently, the issue has open questions about node placement for the injecting class and injected dependencies. A maintainer should clarify these design choices before implementation. The work involves modifying the regex based detection and graph construction, possibly adding new node types.