dtolnay/cxx

Figure out where to put #[inline]

Open

#146 创建于 2020年4月25日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)Rust (4,472 star) (253 fork)batch import
help wanted

描述

In the Rust code generator we currently emit some shims that do nothing more than cast between smart pointers and raw pointers and then dispatch to the appropriate extern "C" function.

These shims should probably be marked #[inline] so that callers are able to directly call the extern "C" function themselves, but ideally I'd like at least one performance measurement showing a benefit before going forward with the change.

贡献者指南

技术栈
rust
领域
performance
议题类型
performance
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
basic Rustfamiliarity with cxx code generator
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate the Rust code generator in the cxx crate to locate the shim functions that cast between smart pointers and raw pointers. Implement a benchmark to measure the performance difference with and without #[inline] annotations on these shims. Report the results in the issue to support the decision to add #[inline].
Figure out where to put #[inline] · dtolnay/cxx#146 | Good First Issue