dtolnay/cargo-expand

Show progress bar

开放

#62 创建于 2019年4月20日

 (0 条评论) (0 个反应) (0 位负责人)Rust (73 个派生)github user discovery
help wanted

仓库指标

星标
 (3,090 个星标)
PR 合并指标
 (平均合并 4分钟) (30 天内合并 1 个 PR)

描述

Currently the Cargo subprocess spawned by cargo-expand does not display Cargo's usual progress bar. I believe this is because we pipe the child's stderr to perform filtering here:

https://github.com/dtolnay/cargo-expand/blob/3ae4ca126a4bd557ef7f7954911d65db56525b37/src/main.rs#L358

and that means Cargo does not get a winsize from this ioctl:

https://github.com/rust-lang/cargo/blob/6be12653dcefb46ee7b605f063ee75b5e6cba513/src/cargo/core/shell.rs#L377

I tried a naive fix in #61 but it didn't work, the second ioctl fails with:

Inappropriate ioctl for device (os error 25)

Will need to figure out what's the correct way to provide a winsize to the child process.

贡献者指南