dthree/vorpal

.catch should not trigger on a command group

Open

#64 创建于 2015年12月21日

在 GitHub 查看
 (2 评论) (1 反应) (0 负责人)JavaScript (5,609 star) (313 fork)batch import
bughelp wanted

描述

when not implementing a catch hook, typing in a command of a group gives you the help for it's subcommands.

if however you implement a catch hook, the catch hook is triggered instead.

I think it would still be useful to show the help for a command group, instead of triggering the catch.

贡献者指南

技术栈
javascriptnodejs
领域
cli
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Node.jsbasic Vorpal knowledge
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Examine Vorpal's command group and catch hook logic in the source code (likely in lib/command.js). Understand how the library distinguishes between a command group and a regular command. The current behavior triggers catch when a group is invoked; the expected behavior is to show help for the group. Modify the command execution flow to skip catch for command groups and instead display help.