dthree/vorpal

Hitting CTRL+C while in Inquirer prompt breaks everything

Open

#42 创建于 2015年11月1日

在 GitHub 查看
 (16 评论) (0 反应) (0 负责人)JavaScript (5,609 star) (313 fork)batch import
bughelp wanted

描述

The output looks like this:

(^C again to quit)
function (str) {
  if (str === undefined) {
    return this._delimiter;
  }
  this._delimiter = String(str).trim() + ' ';
  if (this.isLocal()) {
    this.parent.ui.refresh();
  } else {
    this.parent._send('vantage-delimiter-downstream', 'downstream', {value: str, sessionId: this.id});
  }
  return this;
}
_

You can still type but nothing happens. Only way to recover is hitting CTRL+C again.

贡献者指南

技术栈
javascriptnodejs
领域
cli
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic JavaScriptNode.js CLI developmentUnderstanding of process signals
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Investigate how Vorpal sets up the Inquirer prompt and handles SIGINT signals. Look at the Inquirer library's behavior on Ctrl+C and how it interacts with Vorpal's internal state. The code snippet in the issue shows a function that might be from Vorpal's delimiter logic; check the refresh method and the send method. Consider implementing a proper cleanup or reset of the prompt state on Ctrl+C.