dthree/vorpal

[for discussion] move default localStorage location under $HOME

Open

#122 创建于 2016年3月1日

在 GitHub 查看
 (11 评论) (3 反应) (0 负责人)JavaScript (5,609 star) (313 fork)batch import
bughelp wanted

描述

i ran into a problem when trying out your cash project. With my nodejs/npm setup, global installs require sudo: sudo npm i -g cash

however, because of that, cash doesn't have permissions to write to its own localstorage directory:

$ cash
fs.js:794
  return binding.mkdir(pathModule._makeLong(path),
                 ^

Error: EACCES: permission denied, mkdir '/Users/tenaciousmv/npm/lib/node_modules/cash/node_modules/vorpal/dist/.local_storage'

obviously i don't want to run cash with sudo :)

isn't it more typical to put this kind of storage in ~/.vorpal or ~/.cash or somewhere else under $HOME?

贡献者指南

技术栈
javascriptnodejs
领域
cli
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Node.jsvorpal frameworkbasic file system knowledge
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
The issue suggests moving the default localStorage directory from inside the npm global install path to under the user's home directory (e.g., ~/.vorpal). To fix, locate the code in vorpal that sets the localStorage path (likely in the local storage.js or similar file in the dist folder). Change the default to use os.homedir() or process.env.HOME, and ensure the directory is created with appropriate permissions. Test the change by installing cash globally with sudo and running cash to verify no permission errors.