drivendataorg/cloudpathlib

mark pydantic integration (as an extra?)

开放

#385 创建于 2023年12月11日

 (2 条评论) (0 个反应) (0 位负责人)Python (87 个派生)auto 404
good first issuetyping

仓库指标

星标
 (624 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

We run mypy with ignore_missing_imports = false and then have an explicit allow list for packages. Since cloudpathlib imports pydantic (albeit behind a guard) but does not depends on it, mypy fails with :

cloudpath.py:1207: error: Cannot find implementation or library stub for module named "pydantic_core"  [import-not-found]

We would normally set ignore_missing_imports for just pydantic_core, but that's somewhat wonky in this case because pydantic_core does have type stubs, it's just not a dependency.

I think the most straightforward approach would be to add a pydantic extra to cloudpathlib, but there might be a fancier way to inform mypy directly of the "optional-ness" of the imports.

贡献者指南