downshift-js/downshift

Consider using passive event listeners

Open

#1,650 创建于 2025年5月23日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)JavaScript (11,761 star) (980 fork)batch import
help wantedneeds investigation

描述

When rendering a Downshift component in Chrome, I see this message logged in the console:

[Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952

Chrome developer tools indicates that these listeners are not passive: https://github.com/downshift-js/downshift/blob/master/src/hooks/utils.js#L421-L425

Would it be possible to make these listeners passive without affecting functionality?

贡献者指南

技术栈
javascriptreact
领域
frontendperformance
议题类型
performance
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic JavaScriptReact hooksevent listeners
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
Focus on the file src/hooks/utils.js around lines 421-425 where event listeners are added. Determine if making these listeners passive (by passing { passive: true } as the third argument to addEventListener) will break any existing functionality, such as preventing default behavior. The issue suggests adding passive listeners to improve scroll performance. Review the related Chrome documentation and test the change with downshift components. If passive listeners are safe, implement and verify there are no regressions.