downshift-js/downshift

[useSelect] Selecting item with spacebar in firefox reopens the menu

Open

#1,197 创建于 2020年11月18日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)JavaScript (11,761 star) (980 fork)batch import
bughelp wantedneeds investigation

描述

  • downshift version: 6.0.6
  • firefox version: 82.0.3

Relevant code or config

Error present in reference implementation: https://www.downshift-js.com/use-select

What you did:

With firefox, open a menu and select an item with the spacebar key

What happened:

The item was selected, but the menu was reopened. Closely inspecting the result of onStateChange it is revelead that on key down the __menu_keydown_space_button__ is emitted, and on key up the __togglebutton_click__ is emitted.

Error is not present in chrome.

Reproduction repository:

Problem description:

Suggested solution:

贡献者指南

技术栈
javascriptreact
领域
frontendaccessibility
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
React basicskeyboard events understanding
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Investigate the event handling for the spacebar key in the useSelect hook, focusing on the difference between Firefox and Chrome. Look at the onKeyDown and onClick handlers, particularly how they interact. The issue mentions that in Firefox, keydown emits ' menu keydown space button ' and keyup emits ' togglebutton click ', which causes the menu to reopen. Check the source code in the downshift repository, likely in the useSelect.js file, to see if there is a missing event.preventDefault() or improper event propagation handling. Also, check if the 'onKeyUp' event needs to be suppressed. The reference implementation at https://www.downshift js.com/use select can be used for reproduction.