downshift-js/downshift

TypeScript: have items and selectedItems as Readonly

Open

#1,030 创建于 2020年4月30日

在 GitHub 查看
 (4 评论) (1 反应) (0 负责人)JavaScript (11,761 star) (980 fork)batch import
TypeScripthelp wanted

描述

  • downshift version:
  • node version:
  • npm (or yarn) version:

Relevant code or config

What you did:

What happened:

Reproduction repository:

Problem description: Since we use items/selectedItems just for some logic and we do not tamper with them, we can mark them as read only in the TS interface.

Suggested solution: In typings.ts for useSelect, useCombobox and useMultipleSelection, use Readonly to wrap the items type.

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic TypeScript knowledgeFamiliarity with downshift typings
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
90
研究方向
Locate typings.ts file in the downshift source code. For hooks useSelect, useCombobox, and useMultipleSelection, modify the type definitions to wrap the items and selectedItems properties with Readonly<T> to indicate they are not mutated. Ensure consistency across all three hooks. No logic changes required.