dotnet/wpf

TextFormatter.FormatLine has O(n^2) performance when called multiple times

Open

#6,304 创建于 2022年3月23日

在 GitHub 查看
 (6 评论) (2 反应) (0 负责人)C# (6,683 star) (1,126 fork)batch import
Performancehelp wanted

描述

  • .NET Core Version: .net 6
  • Windows version: 11
  • Does the bug reproduce also in WPF for .NET Framework 4.8?: Yes
  • Is this bug related specifically to tooling in Visual Studio (e.g. XAML Designer, Code editing, etc...)? no

Actual behavior:

TextFormatter.FormatLine has O(n^2) performance

Expected behavior:

TextFormatter.FormatLine exhibits linear performance

Minimal repro: WpfFontRepro.zip

Remarks

Disposing the formatted lines or creating new TextFormatter instances prevents the O(n^2) behavior.

贡献者指南

技术栈
csharp
领域
desktopperformance
议题类型
performance
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C#WPFPerformance profiling
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
Investigate the TextFormatter.FormatLine method in the WPF codebase (likely in TextFormatter.cs). The issue suggests that creating new TextFormatter instances or disposing formatted lines avoids the O(n^2) behavior, indicating improper caching or resource management. Review how FormattedLine objects are stored and disposed, and consider implementing a fix that ensures linear time complexity across multiple calls. The minimal repro provided in the issue can be used to validate the fix.
TextFormatter.FormatLine has O(n^2) performance when called multiple times · dotnet/wpf#6304 | Good First Issue