dotnet/runtime
`GenTreeAddrMode` has implicit truncation for its `gtOffset` field
开放
#86,609 创建于 2023年5月22日
area-CodeGen-coreclrhelp wanted
仓库指标
- 星标
- (17,886 个星标)
- PR 合并指标
- (平均合并 12天 11小时) (30 天内合并 661 个 PR)
描述
The constructor takes in and stores a ssize_t offset: https://github.com/dotnet/runtime/blob/main/src/coreclr/jit/gentree.h#L7089
However, it returns an int Offset() which may result in implicit truncation and loss of data: https://github.com/dotnet/runtime/pull/86400
We should likely change the signature to take in an int and ensure that all taken offsets are in range.