dotnet/runtime

Reconsider the exception type thrown when trying to open a directory as file

Open

#70,275 创建于 2022年6月6日

在 GitHub 查看
 (6 评论) (0 反应) (0 负责人)C# (5,445 fork)batch import
area-System.IOhelp wanted

仓库指标

Star
 (17,886 star)
PR 合并指标
 (平均合并 12天 11小时) (30 天内合并 661 个 PR)

描述

In FileSystem.Windows, as well as SafeFileHandle.Windows we have this comment:

https://github.com/dotnet/runtime/blob/6a56aa3512c912df602bf074dc925b77f3895b24/src/libraries/System.Private.CoreLib/src/System/IO/FileSystem.Windows.cs#L216-L224

However, when testing with native code on Windows 10, calling CreateFileA returns ERROR_PATH_NOT_FOUND for either C:\ or other normal directories.

So this causing behavior inconsistency on managed API again: when calling File.Open on C:\, it throws UnauthorizedException. When calling with other directories, it throws PathNotFoundException.

I didn't find any test for exceptions in System.IO.FileSystem.

Changing the exception thrown is technically breaking, but helps for consistency. Changing to an exception is already used for other circumstances won't break much.

We need to also examine Windows 7 and 8 behavior and the behavior of CreateFile2 and NtCreateFile. (Or if you can directly check it through Windows source code)

贡献者指南