dotnet/roslyn

csc and vbc don't detect recursive response files

Open

#5,874 创建于 2015年10月11日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)C# (20,414 star) (4,257 fork)batch import
Area-CompilersBughelp wanted

描述

As a simple repro, create a minimal response file, test.rs, which just refers to itself:

@test.rs

Now run vbc @test.rs or csc @test.rs and observe what appears to be an infinite loop (1 CPU core spins at 100% and memory usage grows unchecked).
The native compilers (version 4.6.0081.0 on my machine) under Windows\Microsoft.NET\Framework detect when a response file is specified multiple times, recursively or otherwise, and show an error (although the native vbc subsequently crashes).

贡献者指南

技术栈
csharp
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C#compiler internals
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Investigate the response file parsing logic in the command line compiler driver (likely in the CSharpCommandLineParser or VisualBasicCommandLineParser). Look for how recursive includes are handled. The fix likely involves tracking already included response files and detecting cycles. Start by reproducing the issue with a self referencing response file as described.