dotnet/roslyn

'IDE0031 Use null propagation' incorrectly suggested for LINQ expression with left join (DefaultIfEmpty)

开放

#47,788 创建于 2020年9月17日

 (1 条评论) (1 个反应) (0 位负责人)C# (4,257 个派生)batch import
Area-CompilersBugFeature - IDE0031IDE-CodeStylehelp wanted

仓库指标

星标
 (20,414 个星标)
PR 合并指标
 (平均合并 6天 17小时) (30 天内合并 256 个 PR)

描述

[Update: IDE issue was traced to a problem with the GetSymbolInfo Compiler API, in part. See details below. May relate to another issue with visitors on this LINQ query]

Version Used: 16.7.3

The motivating situation that led to me filing https://github.com/dotnet/roslyn/issues/33992 was not covered by the fix for the minimal repro I gave in that issue.

Using the standard LINQ left outer join pattern:

_ = from itemA in new[] { new { X = (int?)1 } }.AsQueryable()
    join itemB in new[] { new { X = (int?)2 } }.AsQueryable() on itemA.X equals itemB.X into itemBGroup
    from itemB in itemBGroup.DefaultIfEmpty()
    //     ↓ IDE0031 Use null propagation
    select itemB == null ? null : itemB.X;

After applying the suggested fix:

_ = from itemA in new[] { new { X = (int?)1 } }.AsQueryable()
    join itemB in new[] { new { X = (int?)2 } }.AsQueryable() on itemA.X equals itemB.X into itemBGroup
    from itemB in itemBGroup.DefaultIfEmpty()
    //     ↓↓↓↓↓↓↓↓ CS8072 An expression tree lambda may not contain a null propagating operator.
    select itemB?.X;

/cc @CyrusNajmabadi

贡献者指南