dotnet/roslyn

[Tests] These tests seem to check SyntaxToken inside of SyntaxNode

Open

#38,311 创建于 2019年8月27日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)C# (20,414 star) (4,257 fork)batch import
Area-CompilersBugTesthelp wanted

描述

See https://github.com/dotnet/roslyn/blob/master/src/Compilers/Core/CodeAnalysisTest/CommonSyntaxTests.cs#L181-201 Names node, token and trivia suggest that this test was intended to test VisualBasicExtensions.Kind methods for SyntaxNode, SyntaxToken and SyntaxTrivia of C#. In fact, both first and second invocation test the same method Kind(this SyntaxToken token), because node is actually a SyntaxToken. The same applies to VisualBasicSyntax_CSharpKind test as well.

贡献者指南

技术栈
csharp
领域
testing
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C#Roslyn Syntax API basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
The issue identifies that in CommonSyntaxTests.cs lines 181-201, the variable 'node' is actually a SyntaxToken, so the test incorrectly uses the SyntaxToken overload of Kind. To fix, either rename the variable to 'token' and call the SyntaxToken overload, or change the method call to the SyntaxNode overload by using the correct variable. The same applies to VisualBasicSyntax CSharpKind test. Ensure both tests verify the intended Kind extension methods.
[Tests] These tests seem to check SyntaxToken inside of SyntaxNode · dotnet/roslyn#38311 | Good First Issue