dotnet/roslyn

VB compiler should not "optimize" Select statements during initial binding

Open

#374 创建于 2015年2月10日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)C# (20,414 star) (4,257 fork)batch import
Area-CompilersBugConcept-Design DebtLanguage-VBhelp wanted

描述

The VB compiler "optimizes" Select statements during initial binding, generating and storing a lowered form for the cases depending on the structure of the whole select statement.

Generally speaking such transformations belong in lowering. Since it operates at the level of the whole Select statement after all of the parts have been bound, it can be moved en masse to a later phase. I recommend the local lowering phase.

Any intermediate phases that depend on the lowering having taken place are likely buggy, since different lowered forms may be generated in different circumstances.

[ported from TFS DevDiv 941313]

贡献者指南

技术栈
csharp
领域
toolingperformance
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
compiler internalsRoslyn architectureVB.NET syntaxlowering phases
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
25
研究方向
Examine the VB compiler's initial binding phase to locate the premature optimization of Select statements. The issue recommends moving this transformation to the local lowering phase. Review the lowering pass structure in the Roslyn repository, likely in the 'Features/VisualBasic' or 'Compilers/VisualBasic' directories. Check linked TFS issue for more context.
VB compiler should not "optimize" Select statements during initial binding · dotnet/roslyn#374 | Good First Issue