dotnet/roslyn

VB parsing string-interpolation in erroneous code has poor error recovery

Open

#3,617 创建于 2015年6月22日

在 GitHub 查看
 (15 评论) (0 反应) (1 负责人)C# (20,414 star) (4,257 fork)batch import
Area-CompilersBugConcept-Diagnostic Clarityhelp wanted

描述

Watch this video: string-interpolation-parsing

I get into this situation often when I'm copying+pasting code around, or breaking a method up into smaller methods by deleting "sub" and then re-adding a bunch of "sub" and "end sub" statements where appropriate.

WHAT I OBSERVE: When there's a valid statement, regular strings and interpolated string parse fine.

When there's an invalid statement, regular strings parse fine, but interpolated strings don't recognize their terminating quote, so the remainder of the entire file gets "stringed out".

WHAT I EXPECT: interpolated strings should believe themselves terminated at the terminating quote, just like regular strings do.

贡献者指南

技术栈
csharp
领域
tooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Visual Basic syntaxcompiler parsing basicserror recovery conceptsRoslyn VB parser code
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate the VB parser's handling of string interpolation in error recovery. Look at the relevant parsing code in the VB syntax parser, likely in files such as 'VbParse.vb' or 'SyntaxParser.vb'. The issue is that interpolated strings do not terminate on the closing quote when there is a prior syntax error. Examine the existing error recovery logic for regular strings versus interpolated strings and propose a fix that ensures the terminating quote is recognized even in error scenarios.
VB parsing string-interpolation in erroneous code has poor error recovery · dotnet/roslyn#3617 | Good First Issue