dotnet/roslyn

Extract interface doesn't respect insert_final_newline editorconfig

Open

#33,868 创建于 2019年3月5日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)C# (20,414 star) (4,257 fork)batch import
Area-IDEBugFeature - Editor ConfigFeature - Extract InterfaceIDE-CodeStylehelp wanted

描述

Version Used: 15.9

Steps to Reproduce:

  1. Run with insert_final_newline=true editorconfig
  2. Run the "Extract Interface" code fix
  3. Look at the generated file

Expected Behavior: The last character(s) are a line break

Actual Behavior: The last character in the file is the closing curly brace of the namespace and git says "No newline at end of file"

贡献者指南

技术栈
csharp
领域
tooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic C# knowledgeUnderstanding of editorconfig
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Look into the Extract Interface code fix within the Roslyn codebase, likely in src/Features/ExtractInterface. Investigate how editorconfig settings like insert final newline are applied to generated code. Check other code fixes for consistency, e.g., in CSharpCodeGenerationOptions. The fix should ensure a newline is appended at the end of the generated file.