dotnet/roslyn

VB boolean literals not highlighted as keywords in SymbolDisplay.ToDisplayParts

Open

#30,960 创建于 2018年11月5日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)C# (20,414 star) (4,257 fork)batch import
4 - In ReviewArea-CompilersBughelp wanted

描述

Create a C# project and a VB project referencing it. C# file:

public class CS
{
    public const bool Const = true;
}

VB with completion invoked at |.

Module VB
    Sub M()
        CS.|
    End Sub
End Module

image Expected behavior: True is colored as a keyword Actual behavior: it's not

This is because in the result of calling SymbolDisplay.ToDisplayParts on the field, the part with the true keyword has a kind of SymbolDisplayPartKind.NumericLiteral as opposed to SymbolDisplayPartKind.Keyword (so this bug is in the compiler).

贡献者指南

技术栈
csharp
领域
developer experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C# compiler internalsSymbolDisplay API
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Examine the SymbolDisplay.ToDisplayParts method in the Roslyn compiler source code. The bug is that for VB boolean literals like 'True', the part kind is incorrectly set to NumericLiteral instead of Keyword. Focus on the code that determines the kind for constant values, likely in semantic model or display utilities. The issue has a clear reproduction and expected behavior, so a fix would involve updating the condition that assigns the kind for boolean constants.