dotnet/roslyn

Commas, angle brackets dismiss signature help in strings

开放

#29,669 创建于 2018年9月4日

 (3 条评论) (1 个反应) (0 位负责人)C# (4,257 个派生)batch import
Area-IDEBughelp wanted

仓库指标

星标
 (20,414 个星标)
PR 合并指标
 (平均合并 6天 17小时) (30 天内合并 256 个 PR)

描述

signaturehelpcommasasretriggers

TL;DR

We believe that all of C#'s trigger characters should probably be considered retrigger characters.

Context

We (@jessetrinity, @sana-ajani, @amcasey and I on the TypeScript team) are trying to tackle the Visual Studio side of https://github.com/Microsoft/TypeScript/issues/1150. We noticed that the most "intuitive" implementation actually results in the undesirable behavior highlighted above. When checking to see what C# does, we saw the same behavior. Rather than diverging, we wanted to consult with Roslyn first to verify whether this is a bug.

Details

Version Used: Latest

Steps to Reproduce:

  1. Write a method Foo accepting a string
  2. Trigger signature help session within a string literal being passed to Foo
  3. Enter a comma character within the string (,)

Expected Behavior:

Signature help remains

Actual Behavior:

Signature help is dismissed

贡献者指南