dotnet/roslyn

Should protected abstract methods in SemanticModel be private protected instead?

开放

#29,235 创建于 2018年8月12日

 (0 条评论) (0 个反应) (0 位负责人)C# (4,257 个派生)batch import
Area-CompilersBugConcept-APIhelp wanted

仓库指标

星标
 (20,414 个星标)
PR 合并指标
 (平均合并 6天 17小时) (30 天内合并 256 个 PR)

描述

I noticed that protected abstract methods on SemanticModel like GetDeclaredSymbolCore are documented in Roslyn's API reference. Since it's impossible to inherit from SemanticModel for users of the API, I think such methods should not be included in the API reference.

And I think the most reasonable way to do that is to change such methods to private protected. Do you agree?

It's possible there are more types like that in the codebase, but SemanticModel is the one where I noticed this.

贡献者指南