dotnet/roslyn

DiagnosticLogger.LogHyperlink uses GetHashCode() to persist data

Open

#2,160 创建于 2015年4月21日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)C# (20,414 star) (4,257 fork)batch import
Area-AnalyzersBughelp wanted

描述

GetHashCode has no guarantee of stability across architectures, runtime implementations, process or AppDomain boundaries, or even build to build (in fact, we used to specifically break GetHashCode in daily CHK builds to prevent internal code from relying on them outside of an AppDomain. Other telemetry is using SHA256 hashes, and LogHyperlink should do the same.

贡献者指南

技术栈
csharp
领域
developer experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C# basicsunderstanding of hash codes
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Locate the DiagnosticLogger.LogHyperlink method in the Roslyn codebase. Identify existing SHA256 hash usage in other telemetry for consistent approach. Replace GetHashCode() call with SHA256 hash computation, ensuring proper disposal of cryptographic objects.
DiagnosticLogger.LogHyperlink uses GetHashCode() to persist data · dotnet/roslyn#2160 | Good First Issue